• Ben Hutchings's avatar
    atl2: Disable unimplemented scatter/gather feature · b5a266d0
    Ben Hutchings authored
    commit f43bfaed upstream.
    
    atl2 includes NETIF_F_SG in hw_features even though it has no support
    for non-linear skbs.  This bug was originally harmless since the
    driver does not claim to implement checksum offload and that used to
    be a requirement for SG.
    
    Now that SG and checksum offload are independent features, if you
    explicitly enable SG *and* use one of the rare protocols that can use
    SG without checkusm offload, this potentially leaks sensitive
    information (before you notice that it just isn't working).  Therefore
    this obscure bug has been designated CVE-2016-2117.
    Reported-by: default avatarJustin Yackoski <jyackoski@crypto-nite.com>
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    Fixes: ec5f0615 ("net: Kill link between CSUM and SG features.")
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    [bwh: Backported to 3.2: adjust context]
    b5a266d0
atl2.c 80.6 KB