• Yonghong Song's avatar
    samples/bpf: silence compiler warning for xdpsock_user.c · b74e21ab
    Yonghong Song authored
    Compiling xdpsock_user.c with 4.8.5, I hit the following
    compilation warning:
        HOSTCC  samples/bpf/xdpsock_user.o
      /data/users/yhs/work/net-next/samples/bpf/xdpsock_user.c: In function ‘main’:
      /data/users/yhs/work/net-next/samples/bpf/xdpsock_user.c:449:6: warning: ‘idx_cq’ may be used unini
      tialized in this function [-Wmaybe-uninitialized]
        u32 idx_cq, idx_fq;
            ^
      /data/users/yhs/work/net-next/samples/bpf/xdpsock_user.c:606:7: warning: ‘idx_rx’ may be used unini
      tialized in this function [-Wmaybe-uninitialized]
         u32 idx_rx, idx_tx = 0;
             ^
      /data/users/yhs/work/net-next/samples/bpf/xdpsock_user.c:506:6: warning: ‘idx_rx’ may be used unini
      tialized in this function [-Wmaybe-uninitialized]
        u32 idx_rx, idx_fq = 0;
    
    As an example, the code pattern looks like:
        u32 idx_cq;
        ...
        ret = xsk_ring_prod__reserve(&xsk->umem->fq, rcvd, &idx_fq);
        if (ret) {
          ...
        }
        ... idx_fq ...
    The compiler warns since it does not know whether &idx_fq is assigned
    or not inside the library function xsk_ring_prod__reserve().
    
    Let us assign an initial value 0 to such auto variables to silence
    compiler warning.
    
    Fixes: 248c7f9c ("samples/bpf: convert xdpsock to use libbpf for AF_XDP access")
    Signed-off-by: default avatarYonghong Song <yhs@fb.com>
    Acked-by: default avatarJonathan Lemon <jonathan.lemon@gmail.com>
    Acked-by: default avatarSong Liu <songliubraving@fb.com>
    Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
    b74e21ab
xdpsock_user.c 15.3 KB