• Giuseppe CAVALLARO's avatar
    stmmac: fix lock in stmmac_set_rx_mode · b9d73704
    Giuseppe CAVALLARO authored
    When compile with CONFIG_PROVE_LOCKING the following warnings happen:
    
    [snip]
    
        HARDIRQ-ON-W at:
                            [<c0480c1c>] _raw_spin_lock+0x3c/0x4c
                            [<c02c2828>] stmmac_set_rx_mode+0x18/0x3c
                            [<c038b2cc>] dev_set_rx_mode+0x1c/0x28
                            [<c038b38c>] __dev_open+0xb4/0xf8
                            [<c038b5a8>] __dev_change_flags+0x94/0x128
                            [<c038b6a8>] dev_change_flags+0x10/0x48
                            [<c062afe0>] ip_auto_config+0x1d4/0x1084
                            [<c000873c>] do_one_initcall+0x108/0x15c
                            [<c060ec50>] kernel_init_freeable+0x1a8/0x248
                            [<c0472cc0>] kernel_init+0x8/0x160
                            [<c000dfc8>] ret_from_fork+0x14/0x2c
         INITIAL USE at:
                           [<c0480c1c>] _raw_spin_lock+0x3c/0x4c
                           [<c02c2828>] stmmac_set_rx_mode+0x18/0x3c
                           [<c038b2cc>] dev_set_rx_mode+0x1c/0x28
                           [<c038b38c>] __dev_open+0xb4/0xf8
                           [<c038b5a8>] __dev_change_flags+0x94/0x128
                           [<c038b6a8>] dev_change_flags+0x10/0x48
                           [<c062afe0>] ip_auto_config+0x1d4/0x1084
                           [<c000873c>] do_one_initcall+0x108/0x15c
                           [<c060ec50>] kernel_init_freeable+0x1a8/0x248
                           [<c0472cc0>] kernel_init+0x8/0x160
                           [<c000dfc8>] ret_from_fork+0x14/0x2c
    
    so the patch just removes the lock protection in the stmmac_set_rx_mode
    Signed-off-by: default avatarGiuseppe Cavallaro <peppe.cavallaro@st.com>
    Cc: Emilio Lopez <emilio@elopez.com.ar>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    b9d73704
stmmac_main.c 85.3 KB