• Chuansheng Liu's avatar
    firmware loader: Fix the concurrent request_firmware() race for kref_get/put · bd9eb7fb
    Chuansheng Liu authored
    There is one race that both request_firmware() with the same
    firmware name.
    
    The race scenerio is as below:
    CPU1                                                  CPU2
    request_firmware() -->
    _request_firmware_load() return err                   another request_firmware() is coming -->
    _request_firmware_cleanup is called -->               _request_firmware_prepare -->
    release_firmware --->                                 fw_lookup_and_allocate_buf -->
                                                          spin_lock(&fwc->lock)
    ...                                                   __fw_lookup_buf() return true
    fw_free_buf() will be called -->                      ...
    kref_put -->
    decrease the refcount to 0
                                                          kref_get(&tmp->ref) ==> it will trigger warning
                                                                                  due to refcount == 0
    __fw_free_buf() -->
    ...                                                   spin_unlock(&fwc->lock)
    spin_lock(&fwc->lock)
    list_del(&buf->list)
    spin_unlock(&fwc->lock)
    kfree(buf)
                                                          After that, the freed buf will be used.
    
    The key race is decreasing refcount to 0 and list_del is not protected together by
    fwc->lock, and it is possible another thread try to get it between refcount==0
    and list_del.
    
    Fix it here to protect it together.
    Acked-by: default avatarMing Lei <ming.lei@canonical.com>
    Signed-off-by: default avatarliu chuansheng <chuansheng.liu@intel.com>
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    bd9eb7fb
firmware_class.c 34.2 KB