• Anirudh Venkataramanan's avatar
    net: thunderbolt: Use kmap_local_page() instead of kmap_atomic() · c3a8d375
    Anirudh Venkataramanan authored
    kmap_atomic() is being deprecated in favor of kmap_local_page(). Replace
    kmap_atomic() and kunmap_atomic() with kmap_local_page() and kunmap_local()
    respectively.
    
    Note that kmap_atomic() disables preemption and page-fault processing, but
    kmap_local_page() doesn't. When converting uses of kmap_atomic(), one has
    to check if the code being executed between the map/unmap implicitly
    depends on page-faults and/or preemption being disabled. If yes, then code
    to disable page-faults and/or preemption should also be added for
    functional correctness. That however doesn't appear to be the case here,
    so just kmap_local_page() is used.
    
    Also note that the page being mapped is not allocated by the driver, and so
    the driver doesn't know if the page is in normal memory. This is the reason
    kmap_local_page() is used as opposed to page_address().
    
    I don't have hardware, so this change has only been compile tested.
    
    Cc: Michael Jamet <michael.jamet@intel.com>
    Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
    Cc: Yehezkel Bernat <YehezkelShB@gmail.com>
    Cc: Ira Weiny <ira.weiny@intel.com>
    Cc: Fabio M. De Francesco <fmdefrancesco@gmail.com>
    Signed-off-by: default avatarAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
    Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c3a8d375
thunderbolt.c 36.3 KB