Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • linux
  • Repository
  • linux
  • drivers
  • block
  • loop.c
Find file BlameHistoryPermalink
  • Petr Vorel's avatar
    loop: Fix occasional uevent drop · c01a21b7
    Petr Vorel authored Nov 12, 2020
    Commit 716ad098 ("loop: Switch to set_capacity_revalidate_and_notify")
    causes an occasional drop of loop device uevent, which are no longer
    triggered in loop_set_size() but in a different part of code.
    
    Bug is reproducible with LTP test uevent01 [1]:
    
    i=0; while true; do
        i=$((i+1)); echo "== $i =="
        lsmod |grep -q loop && rmmod -f loop
        ./uevent01 || break
    done
    
    Put back triggering through code called in loop_set_size().
    
    Fix required to add yet another parameter to
    set_capacity_revalidate_and_notify().
    
    [1] https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/uevents/uevent01.c
    
    [hch: rebased on a different change to the prototype of
     set_capacity_revalidate_and_notify]
    
    Cc: stable@vger.kernel.org # v5.9
    Fixes: 716ad098
    
     ("loop: Switch to set_capacity_revalidate_and_notify")
    Reported-by: default avatar <ltp@lists.linux.it>
    Signed-off-by: default avatarPetr Vorel <pvorel@suse.cz>
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    c01a21b7
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7