• Barry Song's avatar
    mm: swap: reuse exclusive folio directly instead of wp page faults · c18160db
    Barry Song authored
    After swapping out, we perform a swap-in operation.  If we first read and
    then write, we encounter a major fault in do_swap_page for reading, along
    with additional minor faults in do_wp_page for writing.  However, the
    latter appears to be unnecessary and inefficient.  Instead, we can
    directly reuse in do_swap_page and completely eliminate the need for
    do_wp_page.
    
    This patch achieves that optimization specifically for exclusive folios. 
    The following microbenchmark demonstrates the significant reduction in
    minor faults.
    
     #define DATA_SIZE (2UL * 1024 * 1024)
     #define PAGE_SIZE (4UL * 1024)
    
     static void *read_write_data(char *addr)
     {
             char tmp;
    
             for (int i = 0; i < DATA_SIZE; i += PAGE_SIZE) {
                     tmp = *(volatile char *)(addr + i);
                     *(volatile char *)(addr + i) = tmp;
             }
     }
    
     int main(int argc, char **argv)
     {
             struct rusage ru;
    
             char *addr = mmap(NULL, DATA_SIZE, PROT_READ | PROT_WRITE,
                             MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
             memset(addr, 0x11, DATA_SIZE);
    
             do {
                     long old_ru_minflt, old_ru_majflt;
                     long new_ru_minflt, new_ru_majflt;
    
                     madvise(addr, DATA_SIZE, MADV_PAGEOUT);
    
                     getrusage(RUSAGE_SELF, &ru);
                     old_ru_minflt = ru.ru_minflt;
                     old_ru_majflt = ru.ru_majflt;
    
                     read_write_data(addr);
                     getrusage(RUSAGE_SELF, &ru);
                     new_ru_minflt = ru.ru_minflt;
                     new_ru_majflt = ru.ru_majflt;
    
                     printf("minor faults:%ld major faults:%ld\n",
                             new_ru_minflt - old_ru_minflt,
                             new_ru_majflt - old_ru_majflt);
             } while(0);
    
             return 0;
     }
    
    w/o patch,
    / # ~/a.out
    minor faults:512 major faults:512
    
    w/ patch,
    / # ~/a.out
    minor faults:0 major faults:512
    
    Minor faults decrease to 0!
    
    Link: https://lkml.kernel.org/r/20240602004502.26895-1-21cnbao@gmail.comSigned-off-by: default avatarBarry Song <v-songbaohua@oppo.com>
    Acked-by: default avatarDavid Hildenbrand <david@redhat.com>
    Cc: Chris Li <chrisl@kernel.org>
    Cc: Kairui Song <kasong@tencent.com>
    Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
    Cc: Minchan Kim <minchan@kernel.org>
    Cc: Ryan Roberts <ryan.roberts@arm.com>
    Cc: Suren Baghdasaryan <surenb@google.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    c18160db
memory.c 181 KB