• Sebastian Andrzej Siewior's avatar
    net: wan/lmc: Remove lmc_trace() · c2f8c900
    Sebastian Andrzej Siewior authored
    lmc_trace() was first introduced in commit e7a392d5 ("Import
    2.3.99pre6-5") and was not touched ever since.
    
    The reason for looking at this was to get rid of the in_interrupt() usage,
    but while looking at it the following observations were made:
    
     - At least lmc_get_stats() (->ndo_get_stats()) is invoked with disabled
       preemption which is not detected by the in_interrupt() check, which
       would cause schedule() to be called from invalid context.
    
     - The code is hidden behind #ifdef LMC_TRACE which is not defined within
       the kernel and wasn't at the time it was introduced.
    
     - Three jiffies don't match 50ms. msleep() would be a better match which
       would also avoid the schedule() invocation. But why have it to begin
       with?
    
     - Nobody would do something like this today. Either netdev_dbg() or
       trace_printk() or a trace event would be used.  If only the functions
       related to this driver are interesting then ftrace can be used with
       filtering.
    
    As it is obviously broken for years, simply remove it.
    Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c2f8c900
lmc_proto.c 2.73 KB