• Petr Mladek's avatar
    printk: Block console kthreads when direct printing will be required · c3230283
    Petr Mladek authored
    There are known situations when the console kthreads are not
    reliable or does not work in principle, for example, early boot,
    panic, shutdown.
    
    For these situations there is the direct (legacy) mode when printk() tries
    to get console_lock() and flush the messages directly. It works very well
    during the early boot when the console kthreads are not available at all.
    It gets more complicated in the other situations when console kthreads
    might be actively printing and block console_trylock() in printk().
    
    The same problem is in the legacy code as well. Any console_lock()
    owner could block console_trylock() in printk(). It is solved by
    a trick that the current console_lock() owner is responsible for
    printing all pending messages. It is actually the reason why there
    is the risk of softlockups and why the console kthreads were
    introduced.
    
    The console kthreads use the same approach. They are responsible
    for printing the messages by definition. So that they handle
    the messages anytime when they are awake and see new ones.
    The global console_lock is available when there is nothing
    to do.
    
    It should work well when the problematic context is correctly
    detected and printk() switches to the direct mode. But it seems
    that it is not enough in practice. There are reports that
    the messages are not printed during panic() or shutdown()
    even though printk() tries to use the direct mode here.
    
    The problem seems to be that console kthreads become active in these
    situation as well. They steel the job before other CPUs are stopped.
    Then they are stopped in the middle of the job and block the global
    console_lock.
    
    First part of the solution is to block console kthreads when
    the system is in a problematic state and requires the direct
    printk() mode.
    
    Link: https://lore.kernel.org/r/20220610205038.GA3050413@paulmck-ThinkPad-P17-Gen-1
    Link: https://lore.kernel.org/r/CAMdYzYpF4FNTBPZsEFeWRuEwSies36QM_As8osPWZSr2q-viEA@mail.gmail.comSuggested-by: default avatarJohn Ogness <john.ogness@linutronix.de>
    Tested-by: default avatarPaul E. McKenney <paulmck@kernel.org>
    Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
    Link: https://lore.kernel.org/r/20220615162805.27962-2-pmladek@suse.com
    c3230283
printk.c 114 KB