• Al Viro's avatar
    fix short copy handling in copy_mc_pipe_to_iter() · c3497fd0
    Al Viro authored
    Unlike other copying operations on ITER_PIPE, copy_mc_to_iter() can
    result in a short copy.  In that case we need to trim the unused
    buffers, as well as the length of partially filled one - it's not
    enough to set ->head, ->iov_offset and ->count to reflect how
    much had we copied.  Not hard to fix, fortunately...
    
    I'd put a helper (pipe_discard_from(pipe, head)) into pipe_fs_i.h,
    rather than iov_iter.c - it has nothing to do with iov_iter and
    having it will allow us to avoid an ugly kludge in fs/splice.c.
    We could put it into lib/iov_iter.c for now and move it later,
    but I don't see the point going that way...
    
    Cc: stable@kernel.org # 4.19+
    Fixes: ca146f6f "lib/iov_iter: Fix pipe handling in _copy_to_iter_mcsafe()"
    Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
    Reviewed-by: default avatarChristian Brauner (Microsoft) <brauner@kernel.org>
    Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
    c3497fd0
iov_iter.c 49.4 KB