• Clemens Ladisch's avatar
    firewire: core: increase default SPLIT_TIMEOUT value · dd5eeb99
    Clemens Ladisch authored
    The SPLIT_TIMEOUT mechanism is intended to detect requests that somehow
    got lost.  However, when the timeout value is too low, transactions that
    could have been completed successfully will be cancelled.  Furthermore,
    there are chips whose firmwares ignore the configured split timeout and
    send late split response; known examples are the DM1x00 (BeBoB), TCD22x0
    (DICE), and some OXUF936QSE firmwares.
    
    This patch changes the default timeout to two seconds, which happens to
    be the default on other OSes, too.
    
    Actual lost requests are extremely rare, so there should be no practical
    downside to increasing the split timeout even on devices that work
    correctly.
    Signed-off-by: default avatarClemens Ladisch <clemens@ladisch.de>
    Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
    dd5eeb99
core-card.c 18.8 KB