• Arnd Bergmann's avatar
    kbuild: make -Woverride-init warnings more consistent · c40845e3
    Arnd Bergmann authored
    The -Woverride-init warn about code that may be intentional or not,
    but the inintentional ones tend to be real bugs, so there is a bit of
    disagreement on whether this warning option should be enabled by default
    and we have multiple settings in scripts/Makefile.extrawarn as well as
    individual subsystems.
    
    Older versions of clang only supported -Wno-initializer-overrides with
    the same meaning as gcc's -Woverride-init, though all supported versions
    now work with both. Because of this difference, an earlier cleanup of
    mine accidentally turned the clang warning off for W=1 builds and only
    left it on for W=2, while it's still enabled for gcc with W=1.
    
    There is also one driver that only turns the warning off for newer
    versions of gcc but not other compilers, and some but not all the
    Makefiles still use a cc-disable-warning conditional that is no
    longer needed with supported compilers here.
    
    Address all of the above by removing the special cases for clang
    and always turning the warning off unconditionally where it got
    in the way, using the syntax that is supported by both compilers.
    
    Fixes: 2cd3271b ("kbuild: avoid duplicate warning options")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarHamza Mahfooz <hamza.mahfooz@amd.com>
    Acked-by: default avatarJani Nikula <jani.nikula@intel.com>
    Acked-by: default avatarAndrew Jeffery <andrew@codeconstruct.com.au>
    Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
    Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
    c40845e3
Makefile 4.87 KB