• Andrii Nakryiko's avatar
    bpf: fix mark_all_scalars_precise use in mark_chain_precision · c50c0b57
    Andrii Nakryiko authored
    When precision backtracking bails out due to some unsupported sequence
    of instructions (e.g., stack access through register other than r10), we
    need to mark all SCALAR registers as precise to be safe. Currently,
    though, we mark SCALARs precise only starting from the state we detected
    unsupported condition, which could be one of the parent states of the
    actual current state. This will leave some registers potentially not
    marked as precise, even though they should. So make sure we start
    marking scalars as precise from current state (env->cur_state).
    
    Further, we don't currently detect a situation when we end up with some
    stack slots marked as needing precision, but we ran out of available
    states to find the instructions that populate those stack slots. This is
    akin the `i >= func->allocated_stack / BPF_REG_SIZE` check and should be
    handled similarly by falling back to marking all SCALARs precise. Add
    this check when we run out of states.
    Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
    Link: https://lore.kernel.org/r/20230505043317.3629845-8-andrii@kernel.orgSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
    c50c0b57
precise.c 9.03 KB