• Andy Lutomirski's avatar
    x86/entry: Add new, comprehensible entry and exit handlers written in C · c5c46f59
    Andy Lutomirski authored
    The current x86 entry and exit code, written in a mixture of assembly and
    C code, is incomprehensible due to being open-coded in a lot of places
    without coherent documentation.
    
    It appears to work primary by luck and duct tape: i.e. obvious runtime
    failures were fixed on-demand, without re-thinking the design.
    
    Due to those reasons our confidence level in that code is low, and it is
    very difficult to incrementally improve.
    
    Add new code written in C, in preparation for simply deleting the old
    entry code.
    
    prepare_exit_to_usermode() is a new function that will handle all
    slow path exits to user mode.  It is called with IRQs disabled
    and it leaves us in a state in which it is safe to immediately
    return to user mode.  IRQs must not be re-enabled at any point
    after prepare_exit_to_usermode() returns and user mode is actually
    entered. (We can, of course, fail to enter user mode and treat
    that failure as a fresh entry to kernel mode.)
    
    All callers of do_notify_resume() will be migrated to call
    prepare_exit_to_usermode() instead; prepare_exit_to_usermode() needs
    to do everything that do_notify_resume() does today, but it also
    takes care of scheduling and context tracking.  Unlike
    do_notify_resume(), it does not need to be called in a loop.
    
    syscall_return_slowpath() is exactly what it sounds like: it will
    be called on any syscall exit slow path. It will replace
    syscall_trace_leave() and it calls prepare_exit_to_usermode() on the
    way out.
    Signed-off-by: default avatarAndy Lutomirski <luto@kernel.org>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: Denys Vlasenko <vda.linux@googlemail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Rik van Riel <riel@redhat.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: paulmck@linux.vnet.ibm.com
    Link: http://lkml.kernel.org/r/c57c8b87661a4152801d7d3786eac2d1a2f209dd.1435952415.git.luto@kernel.org
    [ Improved the changelog a bit. ]
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    c5c46f59
common.c 9.45 KB