• Imre Deak's avatar
    drm/i915/gen9: Reset secondary power well requests left on by DMC/KVMR · c6782b76
    Imre Deak authored
    DMC forces on power well 1 and the misc IO power well by setting the
    corresponding request bits both in the BIOS and the DEBUG power well
    request registers. This is somewhat unexpected since the firmware should
    really just save and restore state but not alter it. We also depend on
    being able to disable power well 1, and the misc IO power well before
    entering S3/S4 on BXT and SKL or entering DC9 on BXT. To fix this make
    sure these request bits are cleared whenever we want to disable the
    given power wells.
    
    On SKL there is another twist where the firmware also clears the power
    well 1 request bit in HSW_POWER_WELL_DRIVER (but not that of the misc IO
    power well). This happens to not cause a problem due to the forced-on
    request bits in the other request registers.
    
    I've filed a bug about all this, but fixing that may take a while and
    having this sanity check in place makes sense even for future firmware
    versions.
    
    At the same time also check the KVMR request bits. I haven't seen this
    being altered, but we don't expect any request bits in here either, so
    sanitize this register as well.
    
    v2:
    - Apply the workaround on SKL as well. I noticed the related failure
      from the CI report, later Patrik also reported seeing it on his
      machine.
    
    CC: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
    Signed-off-by: default avatarImre Deak <imre.deak@intel.com>
    Reviewed-by: default avatarPatrik Jakobsson <patrik.jakobsson@linux.intel.com>
    Link: http://patchwork.freedesktop.org/patch/msgid/1459851965-6137-1-git-send-email-imre.deak@intel.com
    c6782b76
intel_runtime_pm.c 73.8 KB