• Mauro Carvalho Chehab's avatar
    kconfig: qconf: make search fully work again on split mode · c699eaab
    Mauro Carvalho Chehab authored
    When the search dialog box finds symbols/menus that match
    the search criteria, it presents all results at the window.
    
    Clicking on a search result should make qconf to navigate
    to the selected item. This works on singleMode and on
    fullMode, but on splitMode, the navigation is broken.
    
    This was partially caused by an incomplete Qt5 conversion
    and by the followup patches that restored the original
    behavior.
    
    When qconf is on split mode, it has to update both the
    config and the menu views. Right now, such logic is broken,
    as it is not seeking using the right structures.
    
    On qconf, the screen is split into 3 parts:
    
    	+------------+-------+
    	|            |       |
    	|   Config   | Menu  |
    	|            |       |
    	+------------+-------+
    	|                    |
    	|     ConfigInfo     |
    	|                    |
    	+--------------------+
    
    On singleMode and on fullMode, the menuView is hidden, and search
    updates only the configList (which controls the ConfigView).
    
    On SplitMode, the search logic should detect if the variable is a
    leaf or not. If it is a leaf, it should be presented at the menuView,
    and both configList and menuList should be updated. Otherwise, just
    the configList should be updated.
    
    Link: https://lore.kernel.org/lkml/a98b0f0ebe0c23615a76f1d23f25fd0c84835e6b.camel@redhat.com/Reported-by: default avatarMaxim Levitsky <mlevitsk@redhat.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
    c699eaab
qconf.cc 45.2 KB