• Nathan Chancellor's avatar
    powerpc: Avoid clang uninitialized warning in __get_user_size_allowed · f9cd5f91
    Nathan Chancellor authored
    Commit 9975f852 ("powerpc/uaccess: Remove calls to __get_user_bad()
    and __put_user_bad()") switch to BUILD_BUG() in the default case, which
    leaves x uninitialized. This will not be an issue because the build will
    be broken in that case but clang does static analysis before it realizes
    the default case will be done so it warns about x being uninitialized
    (trimmed for brevity):
    
     In file included from mm/mprotect.c:13:
     In file included from ./include/linux/hugetlb.h:28:
     In file included from ./include/linux/mempolicy.h:16:
     ./include/linux/pagemap.h:772:16: warning: variable '__gu_val' is used
     uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
                     if (unlikely(__get_user(c, uaddr) != 0))
                                  ^~~~~~~~~~~~~~~~~~~~
     ./arch/powerpc/include/asm/uaccess.h:266:2: note: expanded from macro '__get_user'
             __get_user_size_allowed(__gu_val, __gu_addr, __gu_size, __gu_err);      \
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     ./arch/powerpc/include/asm/uaccess.h:235:2: note: expanded from macro
     '__get_user_size_allowed'
            default: BUILD_BUG();                                   \
            ^~~~~~~
    
    Commit 5cd29b1f ("powerpc/uaccess: Use asm goto for get_user when
    compiler supports it") added an initialization for x because of the same
    reason. Do the same thing here so there is no warning across all
    versions of clang.
    Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
    Acked-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    Link: https://github.com/ClangBuiltLinux/linux/issues/1359
    Link: https://lore.kernel.org/r/20210426203518.981550-1-nathan@kernel.org
    f9cd5f91
uaccess.h 13.6 KB