• Hui Zhu's avatar
    zsmalloc: zs_malloc: return ERR_PTR on failure · c7e6f17b
    Hui Zhu authored
    zs_malloc returns 0 if it fails.  zs_zpool_malloc will return -1 when
    zs_malloc return 0.  But -1 makes the return value unclear.
    
    For example, when zswap_frontswap_store calls zs_malloc through
    zs_zpool_malloc, it will return -1 to its caller.  The other return value
    is -EINVAL, -ENODEV or something else.
    
    This commit changes zs_malloc to return ERR_PTR on failure.  It didn't
    just let zs_zpool_malloc return -ENOMEM becaue zs_malloc has two types of
    failure:
    
    - size is not OK return -EINVAL
    - memory alloc fail return -ENOMEM.
    
    Link: https://lkml.kernel.org/r/20220714080757.12161-1-teawater@gmail.comSigned-off-by: default avatarHui Zhu <teawater@antgroup.com>
    Cc: Minchan Kim <minchan@kernel.org>
    Cc: Nitin Gupta <ngupta@vflare.org>
    Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
    Cc: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    c7e6f17b
zram_drv.c 50.7 KB