• Hugh Dickins's avatar
    mm/munlock: mlock_vma_page() check against VM_SPECIAL · c8263bd6
    Hugh Dickins authored
    Although mmap_region() and mlock_fixup() take care that VM_LOCKED
    is never left set on a VM_SPECIAL vma, there is an interval while
    file->f_op->mmap() is using vm_insert_page(s), when VM_LOCKED may
    still be set while VM_SPECIAL bits are added: so mlock_vma_page()
    should ignore VM_LOCKED while any VM_SPECIAL bits are set.
    
    This showed up as a "Bad page" still mlocked, when vfree()ing pages
    which had been vm_inserted by remap_vmalloc_range_partial(): while
    release_pages() and __page_cache_release(), and so put_page(), catch
    pages still mlocked when freeing (and clear_page_mlock() caught them
    when unmapping), the vfree() path is unprepared for them: fix it?
    but these pages should not have been mlocked in the first place.
    
    I assume that an mlockall(MCL_FUTURE) had been done in the past; or
    maybe the user got to specify MAP_LOCKED on a vmalloc'ing driver mmap.
    Signed-off-by: default avatarHugh Dickins <hughd@google.com>
    Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
    c8263bd6
internal.h 23.4 KB