• Christophe Leroy's avatar
    powerpc/64: Fix strncpy() related build failures with GCC 8.1 · c9599881
    Christophe Leroy authored
    GCC 8.1 warns about possible string truncation:
    
      arch/powerpc/kernel/nvram_64.c:1042:2: error: 'strncpy' specified
      bound 12 equals destination size [-Werror=stringop-truncation]
        strncpy(new_part->header.name, name, 12);
    
      arch/powerpc/platforms/ps3/repository.c:106:2: error: 'strncpy'
      output truncated before terminating nul copying 8 bytes from a
      string of the same length [-Werror=stringop-truncation]
        strncpy((char *)&n, text, 8);
    
    Fix it by using memcpy(). To make that safe we need to ensure the
    destination is pre-zeroed. Use kzalloc() in the nvram code and
    initialise the u64 to zero in the ps3 code.
    Signed-off-by: default avatarChristophe Leroy <christophe.leroy@c-s.fr>
    [mpe: Use kzalloc() in the nvram code, flesh out change log]
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    c9599881
nvram_64.c 30.6 KB