• Dmitry Safonov's avatar
    xfrm/compat: Cleanup WARN()s that can be user-triggered · ef19e111
    Dmitry Safonov authored
    Replace WARN_ONCE() that can be triggered from userspace with
    pr_warn_once(). Those still give user a hint what's the issue.
    
    I've left WARN()s that are not possible to trigger with current
    code-base and that would mean that the code has issues:
    - relying on current compat_msg_min[type] <= xfrm_msg_min[type]
    - expected 4-byte padding size difference between
      compat_msg_min[type] and xfrm_msg_min[type]
    - compat_policy[type].len <= xfrma_policy[type].len
    (for every type)
    
    Reported-by: syzbot+834ffd1afc7212eb8147@syzkaller.appspotmail.com
    Fixes: 5f3eea6b ("xfrm/compat: Attach xfrm dumps to 64=>32 bit translator")
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Eric Dumazet <eric.dumazet@gmail.com>
    Cc: Herbert Xu <herbert@gondor.apana.org.au>
    Cc: Jakub Kicinski <kuba@kernel.org>
    Cc: Steffen Klassert <steffen.klassert@secunet.com>
    Cc: netdev@vger.kernel.org
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarDmitry Safonov <dima@arista.com>
    Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
    ef19e111
xfrm_compat.c 18.3 KB