• Hans de Goede's avatar
    ACPI: video: Make acpi_backlight=video work independent from GPU driver · e506731c
    Hans de Goede authored
    Commit 3dbc80a3 ("ACPI: video: Make backlight class device
    registration a separate step (v2)") combined with
    commit 5aa9d943 ("ACPI: video: Don't enable fallback path for
    creating ACPI backlight by default")
    
    Means that the video.ko code now fully depends on the GPU driver calling
    acpi_video_register_backlight() for the acpi_video# backlight class
    devices to get registered.
    
    This means that if the GPU driver does not do this, acpi_backlight=video
    on the cmdline, or DMI quirks for selecting acpi_video# will not work.
    
    This is a problem on for example Apple iMac14,1 all-in-ones where
    the monitor's LCD panel shows up as a regular DP connection instead of
    eDP so the GPU driver will not call acpi_video_register_backlight() [1].
    
    Fix this by making video.ko directly register the acpi_video# devices
    when these have been explicitly requested either on the cmdline or
    through DMI quirks (rather then auto-detection being used).
    
    [1] GPU drivers only call acpi_video_register_backlight() when an internal
    panel is detected, to avoid non working acpi_video# devices getting
    registered on desktops which unfortunately is a real issue.
    
    Fixes: 5aa9d943 ("ACPI: video: Don't enable fallback path for creating ACPI backlight by default")
    Cc: All applicable <stable@vger.kernel.org>
    Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    e506731c
acpi_video.c 59.9 KB