• Jason A. Donenfeld's avatar
    Revert "crypto: poly1305 - cleanup stray CRYPTO_LIB_POLY1305_RSIZE" · ca7984df
    Jason A. Donenfeld authored
    This reverts commit 8bdc2a19.
    
    It got merged a bit prematurely and shortly after the kernel test robot
    and Sudip pointed out build failures:
    
      arm: imx_v6_v7_defconfig and multi_v7_defconfig
      mips: decstation_64_defconfig, decstation_defconfig, decstation_r4k_defconfig
    
      In file included from crypto/chacha20poly1305.c:13:
      include/crypto/poly1305.h:56:46: error: 'CONFIG_CRYPTO_LIB_POLY1305_RSIZE' undeclared here (not in a function); did you mean 'CONFIG_CRYPTO_POLY1305_MODULE'?
         56 |                 struct poly1305_key opaque_r[CONFIG_CRYPTO_LIB_POLY1305_RSIZE];
            |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    We could attempt to fix this by listing the dependencies piecemeal, but
    it's not as obvious as it looks: drivers like caam use this macro in
    headers even if there's no .o compiled in that makes use of it.  So
    actually fixing this might require a bit more of a comprehensive
    approach, rather than whack-a-mole with hunting down which drivers use
    which headers which use this macro.
    
    Therefore, this commit just reverts the change, and maybe the problem
    can be visited on the next rainy day.
    Reported-by: default avatarSudip Mukherjee <sudipm.mukherjee@gmail.com>
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Fixes: 8bdc2a19 ("crypto: poly1305 - cleanup stray CRYPTO_LIB_POLY1305_RSIZE")
    Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    ca7984df
Kconfig 4.08 KB