• Qu Wenruo's avatar
    btrfs: subpage: fix writeback which does not have ordered extent · cc1d0d93
    Qu Wenruo authored
    [BUG]
    When running fsstress with subpage RW support, there are random
    BUG_ON()s triggered with the following trace:
    
     kernel BUG at fs/btrfs/file-item.c:667!
     Internal error: Oops - BUG: 0 [#1] SMP
     CPU: 1 PID: 3486 Comm: kworker/u13:2 5.11.0-rc4-custom+ #43
     Hardware name: Radxa ROCK Pi 4B (DT)
     Workqueue: btrfs-worker-high btrfs_work_helper [btrfs]
     pstate: 60000005 (nZCv daif -PAN -UAO -TCO BTYPE=--)
     pc : btrfs_csum_one_bio+0x420/0x4e0 [btrfs]
     lr : btrfs_csum_one_bio+0x400/0x4e0 [btrfs]
     Call trace:
      btrfs_csum_one_bio+0x420/0x4e0 [btrfs]
      btrfs_submit_bio_start+0x20/0x30 [btrfs]
      run_one_async_start+0x28/0x44 [btrfs]
      btrfs_work_helper+0x128/0x1b4 [btrfs]
      process_one_work+0x22c/0x430
      worker_thread+0x70/0x3a0
      kthread+0x13c/0x140
      ret_from_fork+0x10/0x30
    
    [CAUSE]
    Above BUG_ON() means there is some bio range which doesn't have ordered
    extent, which indeed is worth a BUG_ON().
    
    Unlike regular sectorsize == PAGE_SIZE case, in subpage we have extra
    subpage dirty bitmap to record which range is dirty and should be
    written back.
    
    This means, if we submit bio for a subpage range, we do not only need to
    clear page dirty, but also need to clear subpage dirty bits.
    
    In __extent_writepage_io(), we will call btrfs_page_clear_dirty() for
    any range we submit a bio.
    
    But there is loophole, if we hit a range which is beyond i_size, we just
    call btrfs_writepage_endio_finish_ordered() to finish the ordered io,
    then break out, without clearing the subpage dirty.
    
    This means, if we hit above branch, the subpage dirty bits are still
    there, if other range of the page get dirtied and we need to writeback
    that page again, we will submit bio for the old range, leaving a wild
    bio range which doesn't have ordered extent.
    
    [FIX]
    Fix it by always calling btrfs_page_clear_dirty() in
    __extent_writepage_io().
    
    Also to avoid such problem from happening again, add a new assert,
    btrfs_page_assert_not_dirty(), to make sure both page dirty and subpage
    dirty bits are cleared before exiting __extent_writepage_io().
    Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    cc1d0d93
subpage.c 18 KB