• Boris Burkov's avatar
    btrfs: skip reclaim if block_group is empty · cc4804bf
    Boris Burkov authored
    As we delete extents from a block group, at some deletion we cross below
    the reclaim threshold. It is possible we are still in the middle of
    deleting more extents and might soon hit 0. If the block group is empty
    by the time the reclaim worker runs, we will still relocate it.
    
    This works just fine, as relocating an empty block group ultimately
    results in properly deleting it. However, we have more direct ways of
    removing empty block groups in the cleaner thread. Those are either
    async discard or the unused_bgs list. In fact, when we decide whether to
    relocate a block group during extent deletion, we do check for emptiness
    and prefer the discard/unused_bgs mechanisms when possible.
    
    Not using relocation for this case reduces some modest overhead from
    empty bg relocation:
    
    - extra transactions
    - extra metadata use/churn for creating relocation metadata
    - trying to read the extent tree to look for extents (and in this case
      finding none)
    Reviewed-by: default avatarFilipe Manana <fdmanana@suse.com>
    Signed-off-by: default avatarBoris Burkov <boris@bur.io>
    Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    cc4804bf
block-group.c 124 KB