• Paolo Bonzini's avatar
    x86/apic: Silence "FW_BUG TSC_DEADLINE disabled due to Errata" on hypervisors · cc6afe22
    Paolo Bonzini authored
    Commit 594a30fb ("x86/apic: Silence "FW_BUG TSC_DEADLINE disabled
    due to Errata" on CPUs without the feature", 2017-08-30) was also about
    silencing the warning on VirtualBox; however, KVM does expose the TSC
    deadline timer, and it's virtualized so that it is immune from CPU errata.
    
    Therefore, booting 4.13 with "-cpu Haswell" shows this in the logs:
    
         [    0.000000] [Firmware Bug]: TSC_DEADLINE disabled due to Errata;
                        please update microcode to version: 0xb2 (or later)
    
    Even if you had a hypervisor that does _not_ virtualize the TSC deadline
    and rather exposes the hardware one, it should be the hypervisors task
    to update microcode and possibly hide the flag from CPUID.  So just
    hide the message when running on _any_ hypervisor, not just those that
    do not support the TSC deadline timer.
    
    The older check still makes sense, so keep it.
    
    Fixes: bd9240a1 ("x86/apic: Add TSC_DEADLINE quirk due to errata")
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Hans de Goede <hdegoede@redhat.com>
    Cc: kvm@vger.kernel.org
    Cc: stable@vger.kernel.org
    Link: https://lkml.kernel.org/r/1507630377-54471-1-git-send-email-pbonzini@redhat.com
    cc6afe22
apic.c 66.4 KB