• Steven Rostedt (Google)'s avatar
    tracing: Fix snapshot counter going between two tracers that use it · cca990c7
    Steven Rostedt (Google) authored
    Running the ftrace selftests caused the ring buffer mapping test to fail.
    Investigating, I found that the snapshot counter would be incremented
    every time a tracer that uses the snapshot is enabled even if the snapshot
    was used by the previous tracer.
    
    That is:
    
     # cd /sys/kernel/tracing
     # echo wakeup_rt > current_tracer
     # echo wakeup_dl > current_tracer
     # echo nop > current_tracer
    
    would leave the snapshot counter at 1 and not zero. That's because the
    enabling of wakeup_dl would increment the counter again but the setting
    the tracer to nop would only decrement it once.
    
    Do not arm the snapshot for a tracer if the previous tracer already had it
    armed.
    
    Link: https://lore.kernel.org/linux-trace-kernel/20240223013344.570525723@goodmis.org
    
    Cc: Masami Hiramatsu <mhiramat@kernel.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Vincent Donnefort <vdonnefort@google.com>
    Fixes: 16f7e48ffc53a ("tracing: Add snapshot refcount")
    Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
    cca990c7
trace.c 254 KB