• Matthew Auld's avatar
    drm/xe/uapi: add the userspace bits for small-bar · cd928fce
    Matthew Auld authored
    Mostly the same as i915. We add a new hint for userspace to force an
    object into the mappable part of vram.
    
    We also need to tell userspace how large the mappable part is. In Vulkan
    for example, there will be two vram heaps for small-bar systems. And
    here the size of each heap needs to be known. Likewise the used/avail
    tracking needs to account for the mappable part.
    
    We also limit the available tracking going forward, such that we limit
    to privileged users only, since these values are system wide and are
    technically considered an info leak.
    
    v2 (Maarten):
      - s/NEEDS_CPU_ACCESS/NEEDS_VISIBLE_VRAM/ in the uapi. We also no
        longer require smem as an extra placement. This is more flexible,
        and lets us use this for clear-color surfaces, since we need CPU access
        there but we don't want to attach smem, since that effectively disables
        CCS from kernel pov.
      - Reject clear-color CCS buffers where NEEDS_VISIBLE_VRAM is not set,
        instead of migrating it behind the scenes.
    v3 (José):
      - Split the changes that limit the accounting for perfmon_capable()
        into a separate patch.
      - Use XE_BO_CREATE_VRAM_MASK.
    v4 (Gwan-gyeong Mun):
      - Add some kernel-doc for the query bits.
    v5:
      - One small kernel-doc correction. The cpu_visible_size and
        corresponding used tracking are always zero for non
        XE_MEM_REGION_CLASS_VRAM.
    v6:
      - Without perfmon_capable() it likely makes more sense to report as
        zero, instead of reporting as used == total size. This should give
        similar behaviour as i915 which rather tracks free instead of used.
      - Only enforce NEEDS_VISIBLE_VRAM on rc_ccs_cc_plane surfaces when the
        device is actually small-bar.
    
    Testcase: igt/tests/xe_query
    Testcase: igt/tests/xe_mmap@small-bar
    Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
    Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
    Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
    Cc: Lucas De Marchi <lucas.demarchi@intel.com>
    Cc: José Roberto de Souza <jose.souza@intel.com>
    Cc: Filip Hazubski <filip.hazubski@intel.com>
    Cc: Carl Zhang <carl.zhang@intel.com>
    Cc: Effie Yu <effie.yu@intel.com>
    Reviewed-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
    Reviewed-by: default avatarGwan-gyeong Mun <gwan-gyeong.mun@intel.com>
    Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
    cd928fce
xe_query.c 9.96 KB