• Phil Sutter's avatar
    korina: fix deadlock on RX FIFO overrun · ceb3d239
    Phil Sutter authored
    By calling korina_restart(), the IRQ handler tries to disable the
    interrupt it's currently serving. This leads to a deadlock since
    disable_irq() waits for any running IRQ handlers to finish before
    returning. This patch addresses the issue by turning korina_restart()
    into a workqueue task, which is then scheduled when needed.
    
    Reproducing the deadlock is easily done using e.g. GNU netcat to send
    large amounts of UDP data to the host running this driver.
    
    Note that the same problem (and fix) applies to TX FIFO underruns, but
    apparently these are less easy to trigger.
    Signed-off-by: default avatarPhil Sutter <phil@nwl.cc>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    ceb3d239
korina.c 32.2 KB