• Arnaldo Carvalho de Melo's avatar
    perf: Fix up MMAP2 buffer space reservation · d008d525
    Arnaldo Carvalho de Melo authored
    The ino_generation field was added in the PERF_RECORD_MMAP2 record in
    the 13d7a241 cset but no space for it was allocated, corrupting the
    PERF_FORMAT_{TIME,CPU,TID,etc} area (sample_type/sample_id_all), fix it.
    
    Detected with one of the regression tests done by 'perf test':
    
      [root@sandy ~]# perf test -v 7
       7: Validate PERF_RECORD_* events & perf_sample fields     :
      --- start ---
      61315294449606 0 PERF_RECORD_SAMPLE
      61315294453161 0 PERF_RECORD_SAMPLE
      61315294454441 0 PERF_RECORD_SAMPLE
      61315294455709 0 PERF_RECORD_SAMPLE
      61315295600899 0 PERF_RECORD_COMM: sleep:6500
      27917287430500 342521613 PERF_RECORD_MMAP2 6500/6500: [0x400000(0x7000) @ 0 00:1d 311442 9016]: /usr/bin/sleep
      MMAP2 going backwards in time, prev=61315295600899, curr=27917287430500
      MMAP2 with unexpected cpu, expected 0, got 342521613
      MMAP2 with unexpected pid, expected 6500, got 1701606191
      MMAP2 with unexpected tid, expected 6500, got 28773
      27917287430500 342561333 PERF_RECORD_MMAP2 6500/6500: [0x3b7e000000(0x223000) @ 0 00:1d 309186 9016]: /usr/lib64/ld-2.16.so
      MMAP2 with unexpected cpu, expected 0, got 342561333
      MMAP2 with unexpected pid, expected 6500, got 1932408369
      MMAP2 with unexpected tid, expected 6500, got 111
      27917287430500 342600095 PERF_RECORD_MMAP2 6500/6500: [0x7fffbd7dc000(0x1000) @ 0x7fffbd7dc000 00:00 0 0]: [vdso]
      MMAP2 with unexpected cpu, expected 0, got 342600095
      MMAP2 with unexpected pid, expected 6500, got 1935963739
      MMAP2 with unexpected tid, expected 6500, got 23919
      27917287430500 342882834 PERF_RECORD_MMAP2 6500/6500: [0x3b7e400000(0x3b8000) @ 0 00:1d 309187 9016]: /usr/lib64/libc-2.16.so
      MMAP2 with unexpected cpu, expected 0, got 342882834
      MMAP2 with unexpected pid, expected 6500, got 909192754
      MMAP2 with unexpected tid, expected 6500, got 7303982
      61316297195411 0 PERF_RECORD_EXIT(6500:6500):(6500:6500)
      ---- end ----
      Validate PERF_RECORD_* events & perf_sample fields: FAILED!
      [root@sandy ~]#
    
    After this patch:
    
      [root@sandy ~]# perf test 7
       7: Validate PERF_RECORD_* events & perf_sample fields     : Ok
      [root@sandy ~]#
    Acked-by: default avatarPeter Zijlstra <peterz@infradead.org>
    Acked-by: default avatarStephane Eranian <eranian@google.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/n/tip-heeuv986b8ha7whqg4o3he7c@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    d008d525
core.c 185 KB