• Arnd Bergmann's avatar
    tick/sched: Fix build failure for CONFIG_NO_HZ_COMMON=n · a184d983
    Arnd Bergmann authored
    In configurations with CONFIG_TICK_ONESHOT but no CONFIG_NO_HZ or
    CONFIG_HIGH_RES_TIMERS, tick_sched_timer_dying() is stubbed out,
    but still defined as a global function as well:
    
    kernel/time/tick-sched.c:1599:6: error: redefinition of 'tick_sched_timer_dying'
     1599 | void tick_sched_timer_dying(int cpu)
          |      ^
    kernel/time/tick-sched.h:111:20: note: previous definition is here
      111 | static inline void tick_sched_timer_dying(int cpu) { }
          |                    ^
    
    This configuration only appears with ARM CONFIG_ARCH_BCM_MOBILE,
    which should not actually select CONFIG_TICK_ONESHOT.
    
    Adjust the #ifdef for the stub to match the condition for building the
    tick-sched.c file for consistency with the definition and to avoid
    the build regression.
    
    Fixes: 3aedb7fc ("tick/sched: Remove useless oneshot ifdeffery")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Link: https://lore.kernel.org/r/20240228123850.3499024-1-arnd@kernel.org
    a184d983
tick-sched.h 3.84 KB