• Jean Delvare's avatar
    sound: ASoC: Fix an error path in neo1973_wm8753 · d280289e
    Jean Delvare authored
    The error handling in neo1973_init is incorrect:
    
    * If platform_device_add fails, we go on with the rest of the
      initialization instead of bailing out. Things will break when the
      module is removed (platform_device_unregister called on a device
      that wasn't registered.)
    
    * If i2c_add_driver fails, we return an error so the module will not
      load, but we don't unregister neo1973_snd_device, so we are leaking
      resources.
    
    Add the missing error handling.
    Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
    Cc: Tim Niemeyer <reddog@mastersword.de>
    Cc: Graeme Gregory <graeme@openmoko.org>
    Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
    Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
    Signed-off-by: default avatarJaroslav Kysela <perex@perex.cz>
    d280289e
neo1973_wm8753.c 19 KB