• Lee Jones's avatar
    mfd: asic3: Fix a plethora of Checkpatch errors and warnings · d43c4290
    Lee Jones authored
    ERROR: Macros with complex values should be enclosed in parentheses
    +#define INIT_CDEX(_name, _rate)        \
    +       [ASIC3_CLOCK_##_name] = {               \
    +               .cdex = CLOCK_CDEX_##_name,     \
    +               .rate = _rate,                  \
    +       }
    
    WARNING: line over 80 characters
    +                                                           ASIC3_GPIO_INT_STATUS);
    
    WARNING: void function return statements are not generally useful
    +       return;
    +}
    
    WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
    +       msleep(1);
    
    WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
    +       msleep(1);
    
    WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
    +       msleep(1);
    
    WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
    +       msleep(1);
    
    WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
    +       msleep(1);
    
    WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
    +       msleep(1);
    
    WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
    +               msleep(1);
    WARNING: line over 80 characters
    +               asic->tmio_cnf = ioremap((ASIC3_SD_CONFIG_BASE >> asic->bus_shift) +
    
    WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then p
    r_err(...  to printk(KERN_ERR ...
    +               printk(KERN_ERR "kzalloc failed\n");
    
    WARNING: Possible unnecessary 'out of memory' message
    +       if (asic == NULL) {
    +               printk(KERN_ERR "kzalloc failed\n");
    
    WARNING: Missing a blank line after declarations
    +       int retval = 0;
    +       retval = platform_driver_probe(&asic3_device_driver, asic3_probe);
    
    total: 1 errors, 13 warnings, 1081 lines checked
    Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
    d43c4290
asic3.c 26.8 KB