• Gustavo A. R. Silva's avatar
    leds: pwm: Use struct_size() helper · d4b02200
    Gustavo A. R. Silva authored
    One of the more common cases of allocation size calculations is finding
    the size of a structure that has a zero-sized array at the end, along
    with memory for some number of elements for that array. For example:
    
    struct led_pwm_priv {
    	...
            struct led_pwm_data leds[0];
    };
    
    Make use of the struct_size() helper instead of an open-coded version
    in order to avoid any potential type mistakes.
    
    So, replace the following function:
    
    static inline size_t sizeof_pwm_leds_priv(int num_leds)
    {
           return sizeof(struct led_pwm_priv) +
                         (sizeof(struct led_pwm_data) * num_leds);
    }
    
    with:
    
    struct_size(priv, leds, count)
    
    This code was detected with the help of Coccinelle.
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    Reviewed-by: default avatarKees Cook <keescook@chromium.org>
    Signed-off-by: default avatarJacek Anaszewski <jacek.anaszewski@gmail.com>
    d4b02200
leds-pwm.c 4.7 KB