• Darrick J. Wong's avatar
    xfs: allow the user to cancel repairs before we start writing · d728f4e3
    Darrick J. Wong authored
    All online repair functions have the same structure: walk filesystem
    metadata structures gathering enough data to rebuild the structure,
    stage a new copy, and then commit the new copy.
    
    The gathering steps do not write anything to disk, so they are peppered
    with xchk_should_terminate calls to avoid softlockup warnings and to
    provide an opportunity to abort the repair (by killing xfs_scrub).
    However, it's not clear in the code base when is the last chance to
    abort cleanly without having to undo a bunch of structure.
    
    Therefore, add one more call to xchk_should_terminate (along with a
    comment) providing the sysadmin with the ability to abort before it's
    too late and to make it clear in the source code when it's no longer
    convenient or safe to abort a repair.   As there are only four repair
    functions right now, this patch exists more to establish a precedent for
    subsequent additions than to deliver practical functionality.
    Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
    Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
    d728f4e3
agheader_repair.c 26.7 KB