• David Howells's avatar
    X.509: Fix certificate gathering · d7ec435f
    David Howells authored
    Fix the gathering of certificates from both the source tree and the build tree
    to correctly calculate the pathnames of all the certificates.
    
    The problem was that if the default generated cert, signing_key.x509, didn't
    exist then it would not have a path attached and if it did, it would have a
    path attached.
    
    This means that the contents of kernel/.x509.list would change between the
    first compilation in a directory and the second.  After the second it would
    remain stable because the signing_key.x509 file exists.
    
    The consequence was that the kernel would get relinked unconditionally on the
    second recompilation.  The second recompilation would also show something like
    this:
    
       X.509 certificate list changed
         CERTS   kernel/x509_certificate_list
         - Including cert /home/torvalds/v2.6/linux/signing_key.x509
         AS      kernel/system_certificates.o
         LD      kernel/built-in.o
    
    which is why the relink would happen.
    
    
    Unfortunately, it isn't a simple matter of just sticking a path on the front
    of the filename of the certificate in the build directory as make can't then
    work out how to build it.
    
    So the path has to be prepended to the name for sorting and duplicate
    elimination and then removed for the make rule if it is in the build tree.
    Reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    d7ec435f
Makefile 7.62 KB