• Jani Nikula's avatar
    Revert "drm/i915/edp: Allow alternate fixed mode for eDP if available." · d93fa1b4
    Jani Nikula authored
    This reverts commit dc911f5b.
    
    Per the report, no matter what display mode you select with xrandr, the
    i915 driver will always select the alternate fixed mode. For the
    reporter this means that the display will always run at 40Hz which is
    quite annoying. This may be due to the mode comparison.
    
    But there are some other potential issues. The choice of alt_fixed_mode
    seems dubious. It's the first non-preferred mode, but there are no
    guarantees that the only difference would be refresh rate. Similarly,
    there may be more than one preferred mode in the probed modes list, and
    the commit changes the preferred mode selection to choose the last one
    on the list instead of the first.
    
    (Note that the probed modes list is the raw, unfiltered, unsorted list
    of modes from drm_add_edid_modes(), not the pretty result after a
    drm_helper_probe_single_connector_modes() call.)
    
    Finally, we already have eerily similar code in place to find the
    downclock mode for DRRS that seems like could be reused here.
    
    Back to the drawing board.
    
    Note: This is a hand-crafted revert due to conflicts. If it fails to
    backport, please just try reverting the original commit directly.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105469Reported-by: default avatarRune Petersen <rune@megahurts.dk>
    Reported-by: default avatarMark Spencer <n7u4722r35@ynzlx.anonbox.net>
    Fixes: dc911f5b ("drm/i915/edp: Allow alternate fixed mode for eDP if available.")
    Cc: Clint Taylor <clinton.a.taylor@intel.com>
    Cc: David Weinehall <david.weinehall@linux.intel.com>
    Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
    Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
    Cc: Jani Nikula <jani.nikula@intel.com>
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Jim Bride <jim.bride@linux.intel.com>
    Cc: Jani Nikula <jani.nikula@linux.intel.com>
    Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Cc: intel-gfx@lists.freedesktop.org
    Cc: <stable@vger.kernel.org> # v4.14+
    Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
    Reviewed-by: default avatarDhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20180516080110.22770-1-jani.nikula@intel.com
    d93fa1b4
intel_lvds.c 34.1 KB