• Nathan Chancellor's avatar
    clk: sunxi: Fix operator precedence in sunxi_divs_clk_setup · afdc74ed
    Nathan Chancellor authored
    r375326 in Clang exposes an issue with operator precedence in
    sunxi_div_clk_setup:
    
    drivers/clk/sunxi/clk-sunxi.c:1083:30: warning: operator '?:' has lower
    precedence than '|'; '|' will be evaluated first
    [-Wbitwise-conditional-parentheses]
                                                     data->div[i].critical ?
                                                     ~~~~~~~~~~~~~~~~~~~~~ ^
    drivers/clk/sunxi/clk-sunxi.c:1083:30: note: place parentheses around
    the '|' expression to silence this warning
                                                     data->div[i].critical ?
                                                                           ^
                                                                          )
    drivers/clk/sunxi/clk-sunxi.c:1083:30: note: place parentheses around
    the '?:' expression to evaluate it first
                                                     data->div[i].critical ?
                                                                           ^
                                                     (
    1 warning generated.
    
    It appears that the intention was for ?: to be evaluated first so that
    CLK_IS_CRITICAL could be added to clkflags if the critical boolean was
    set; right now, | is being evaluated first. Add parentheses around the
    ?: block to have it be evaluated first.
    
    Fixes: 9919d44f ("clk: sunxi: Use CLK_IS_CRITICAL flag for critical clks")
    Link: https://github.com/ClangBuiltLinux/linux/issues/745Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
    Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
    afdc74ed
clk-sunxi.c 27.1 KB