• Namhyung Kim's avatar
    perf annotate: Pass "-l" option to objdump conditionally · ded8c484
    Namhyung Kim authored
    The "-l" option is to print line numbers in the objdump output.  perf
    annotate TUI only can show the line numbers later but it causes big slow
    downs for the kernel binary.
    
    Similarly, showing source code also takes a long time and it already has
    an option to control it.
    
      $ time objdump ... -d -S -C vmlinux > /dev/null
      real	0m3.474s
      user	0m3.047s
      sys	0m0.428s
    
      $ time objdump ... -d -l -C vmlinux > /dev/null
      real	0m1.796s
      user	0m1.459s
      sys	0m0.338s
    
      $ time objdump ... -d -C vmlinux > /dev/null
      real	0m0.051s
      user	0m0.036s
      sys	0m0.016s
    
    As it's not needed for data type profiling, let's make it conditional so
    that it can skip the unnecessary work.
    Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Masami Hiramatsu (Google) <mhiramat@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: linux-toolchains@vger.kernel.org
    Cc: linux-trace-devel@vger.kernel.org
    Link: https://lore.kernel.org/r/20231110000012.3538610-2-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    ded8c484
annotate.c 84.7 KB