• Maximilian Luz's avatar
    HID: surface-hid: Fix get-report request · 2b2bcc76
    Maximilian Luz authored
    Getting a report (e.g. feature report) from a device requires us to send
    a request indicating which report we want to retrieve and then waiting
    for the corresponding response containing that report. We already
    provide the response structure to the request call, but the request
    isn't marked as a request that expects a response. Thus the request
    returns before we receive the response and the response buffer indicates
    a zero length response due to that.
    
    This essentially means that the get-report calls are broken and will
    always indicate that a report of length zero has been read.
    
    Fix this by appropriately marking the request.
    
    Fixes: b05ff100 ("HID: Add support for Surface Aggregator Module HID transport")
    Signed-off-by: default avatarMaximilian Luz <luzmaximilian@gmail.com>
    Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
    2b2bcc76
surface_hid.c 6.77 KB