• H Hartley Sweeten's avatar
    ep93xx_eth.c general cleanup · df2f7ec8
    H Hartley Sweeten authored
    General cleanup of the ep93xx_eth driver.
    
    1) Use pr_fmt() to prefix the module name and __func__ to the error 
       messages.
    2) <linux/io.h> instead of <asm/io.h>
    3) <mach/hardware.h> instead of <mach/ep93xx-regs.h> and <mach/platform.h>
    4) Move the ep93xx_mdio_read (and ep93xx_mdio_write) function to eliminate
       the function prototype.
    5) Change all the printk(<level> messages to pr_<level> and remove the 
       __func__ argument.
    6) Use platform_get_{resource/irq} to get the platform resources and add
       an error check.
    7) Use resource_size() for request_mem_region() and ioremap().
    8) Use %pM to print the MAC address at the end of the probe.
    9) Use dev->dev_addr not data->dev_addr for the MAC argument because a
       random address could be used if the platform does not supply one.
    
    The message at the end of the probe is left as a printk since it displays
    cleaner without the function name that would be displayed with pr_info().
    Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
    Acked-by: default avatarLennert Buytenhek <kernel@wantstofly.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    df2f7ec8
ep93xx_eth.c 21.1 KB