• Vaibhav Gupta's avatar
    fbdev: lxfb: use generic power management · df7a9ec3
    Vaibhav Gupta authored
    Switch to the new generic framework by updating function signatures and
    define a "struct dev_pm_ops" variable to bind PM callbacks. This way we can
    remove the legacy .suspend & .resume bindings from "lxfb_driver".
    
    The lxfb_suspend() is designed to function only in the case of Suspend.
    Thus, the code was kept inside "if (state.event == PM_EVENT_SUSPEND)"
    container. This is because, in the legacy framework, this callback was
    invoked even in the event of Freeze and Hibernate. Hence, added the load of
    unnecessary function-calls.
    
    The goal can be achieved by binding the callback with only
    "lxfb_pm_ops.suspend" in the new framework. This also avoids the step of
    checking "if (state.event == PM_EVENT_SUSPEND)" every time the callback is
    invoked.
    Signed-off-by: default avatarVaibhav Gupta <vaibhavgupta40@gmail.com>
    Cc: Bjorn Helgaas <helgaas@kernel.org>
    Cc: Bjorn Helgaas <bhelgaas@google.com>
    Cc: Bjorn Helgaas <bjorn@helgaas.com>
    Cc: Vaibhav Gupta <vaibhav.varodek@gmail.com>
    Cc: Sam Ravnborg <sam@ravnborg.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Russell King <linux@armlinux.org.uk>
    Cc: Andres Salomon <dilinger@queued.net>
    CC: Antonino Daplas <adaplas@gmail.com>
    Cc: Shuah Khan <skhan@linuxfoundation.org>
    Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200819185654.151170-3-vaibhavgupta40@gmail.com
    df7a9ec3
lxfb_ops.c 20.3 KB