• Damien Le Moal's avatar
    null_blk: Fix scheduling in atomic with zoned mode · e1777d09
    Damien Le Moal authored
    Commit aa1c09cb ("null_blk: Fix locking in zoned mode") changed
    zone locking to using the potentially sleeping wait_on_bit_io()
    function. This is acceptable when memory backing is enabled as the
    device queue is in that case marked as blocking, but this triggers a
    scheduling while in atomic context with memory backing disabled.
    
    Fix this by relying solely on the device zone spinlock for zone
    information protection without temporarily releasing this lock around
    null_process_cmd() execution in null_zone_write(). This is OK to do
    since when memory backing is disabled, command processing does not
    block and the memory backing lock nullb->lock is unused. This solution
    avoids the overhead of having to mark a zoned null_blk device queue as
    blocking when memory backing is unused.
    
    This patch also adds comments to the zone locking code to explain the
    unusual locking scheme.
    
    Fixes: aa1c09cb ("null_blk: Fix locking in zoned mode")
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Signed-off-by: default avatarDamien Le Moal <damien.lemoal@wdc.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    e1777d09
null_blk_zoned.c 15 KB