• Ian Rogers's avatar
    perf parse-events: Inline parse_events_evlist_error · e18601d8
    Ian Rogers authored
    Inline parse_events_evlist_error that is only used in
    parse_events_error. Modify parse_events_error to not report a parser
    error unless errors haven't already been reported. Make it clearer
    that the latter case only happens for unrecognized input.
    
    Before:
    
      $ perf stat -e 'cycles/period=99999999999999999999/' true
      event syntax error: 'cycles/period=99999999999999999999/'
                                        \___ parser error
    
      event syntax error: '..les/period=99999999999999999999/'
                                        \___ Bad base 10 number "99999999999999999999"
      Run 'perf list' for a list of valid events
    
       Usage: perf stat [<options>] [<command>]
    
          -e, --event <event>   event selector. use 'perf list' to list available events
      $ perf stat -e 'cycles:xyz' true
      event syntax error: 'cycles:xyz'
                                 \___ parser error
      Run 'perf list' for a list of valid events
    
       Usage: perf stat [<options>] [<command>]
    
          -e, --event <event>   event selector. use 'perf list' to list available events
    
    After:
    
      $ perf stat -e 'cycles/period=99999999999999999999/xyz' true
      event syntax error: '..les/period=99999999999999999999/xyz'
                                        \___ Bad base 10 number "99999999999999999999"
      Run 'perf list' for a list of valid events
    
       Usage: perf stat [<options>] [<command>]
    
          -e, --event <event>   event selector. use 'perf list' to list available events
      $ perf stat -e 'cycles:xyz' true
      event syntax error: 'cycles:xyz'
                                 \___ Unrecognized input
      Run 'perf list' for a list of valid events
    
       Usage: perf stat [<options>] [<command>]
    
          -e, --event <event>   event selector. use 'perf list' to list available events
    Signed-off-by: default avatarIan Rogers <irogers@google.com>
    Reviewed-by: default avatarKan Liang <kan.liang@linux.intel.com>
    Tested-by: default avatarAtish Patra <atishp@rivosinc.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Beeman Strong <beeman@rivosinc.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: James Clark <james.clark@arm.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: https://lore.kernel.org/r/20240416061533.921723-13-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    e18601d8
parse-events.h 8.91 KB