• Mike Christie's avatar
    scsi: iscsi: Remove iscsi_get_task back_lock requirement · e1c6a7ec
    Mike Christie authored
    We currently require that the back_lock is held when calling the functions
    that manipulate the iscsi_task refcount. The only reason for this is to
    handle races where we are handling SCSI-ml EH callbacks and the cmd is
    completing at the same time the normal completion path is running, and we
    can't return from the EH callback until the driver has stopped accessing
    the cmd. Holding the back_lock while also accessing the task->state made it
    simple to check that a cmd is completing and also get/put a refcount at the
    same time, and at the time we were not as concerned about performance.
    
    The problem is that we don't want to take the back_lock from the xmit path
    for normal I/O since it causes contention with the completion path if the
    user has chosen to try and split those paths on different CPUs (in this
    case abusing the CPUs and ignoring caching improves perf for some uses).
    
    Begins to remove the back_lock requirement for iscsi_get/put_task by
    removing the requirement for the get path. Instead of always holding the
    back_lock we detect if something has done the last put and is about to call
    iscsi_free_task(). A subsequent commit will then allow iSCSI code to do the
    last put on a task and only grab the back_lock if the refcount is now zero
    and it's going to call iscsi_free_task().
    
    Link: https://lore.kernel.org/r/20220616224557.115234-8-michael.christie@oracle.comReviewed-by: default avatarLee Duncan <lduncan@suse.com>
    Signed-off-by: default avatarMike Christie <michael.christie@oracle.com>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    e1c6a7ec
libiscsi_tcp.c 33.1 KB