• Ingo Molnar's avatar
    x86/mm: Add missing <asm/cpufeatures.h> dependency to <asm/page_64.h> · e1cd82a3
    Ingo Molnar authored
    In the following commit:
    
      025768a9 x86/cpu: Use alternative to generate the TASK_SIZE_MAX constant
    
    ... we added the new task_size_max() inline, which uses X86_FEATURE_LA57,
    but doesn't include <asm/cpufeatures.h> which defines the constant.
    
    Due to the way alternatives macros work currently this doesn't get reported as an
    immediate build error, only as a link error, if a .c file happens to include
    <asm/page.h> first:
    
       > ld: kernel/fork.o:(.altinstructions+0x98): undefined reference to `X86_FEATURE_LA57'
    
    In the current upstream kernel no .c file includes <asm/page.h> before including
    some other header that includes <asm/cpufeatures.h>, which is why this dependency
    bug went unnoticed.
    
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    e1cd82a3
page_64.h 2.69 KB