• Arnd Bergmann's avatar
    ASoC: cs35l32: avoid uninitialized variable access · dd5dc001
    Arnd Bergmann authored
    gcc warns about the possibilty of accessing a property read from
    devicetree in cs35l32_i2c_probe() when it has not been initialized
    because CONFIG_OF is disabled:
    
    sound/soc/codecs/cs35l32.c: In function 'cs35l32_i2c_probe':
    sound/soc/codecs/cs35l32.c:278:2: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
    
    The code is actually correct because it checks the dev->of_node
    variable first and we know this is NULL here when CONFIG_OF
    is disabled, but Russell King noticed that it's broken when
    we probe the device using DT, and the properties are absent.
    
    The code already has some checking for incorrect values, and
    I keep that checking unchanged here, but add an additional
    check for an error returned by the property accessor functions
    that now gets handled the same way as incorrect data in the
    properties.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarBrian Austin <brian.austin@cirrus.com>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    dd5dc001
cs35l32.c 15 KB