• Ian Rogers's avatar
    perf env: Remove unnecessary NULL tests · e2372136
    Ian Rogers authored
    clang-tidy was warning:
    ```
    util/env.c:334:23: warning: Access to field 'nr_pmu_mappings' results in a dereference of a null pointer (loaded from variable 'env') [clang-analyzer-core.NullDereference]
            env->nr_pmu_mappings = pmu_num;
    ```
    
    As functions are called potentially when !env was true. This condition
    could never be true as it would produce a segv, so remove the
    unnecessary NULL tests and silence clang-tidy.
    Signed-off-by: default avatarIan Rogers <irogers@google.com>
    Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Cc: Ravi Bangoria <ravi.bangoria@amd.com>
    Cc: Nick Desaulniers <ndesaulniers@google.com>
    Cc: Yang Jihong <yangjihong1@huawei.com>
    Cc: Huacai Chen <chenhuacai@kernel.org>
    Cc: Nathan Chancellor <nathan@kernel.org>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: llvm@lists.linux.dev
    Cc: Ming Wang <wangming01@loongson.cn>
    Cc: Tom Rix <trix@redhat.com>
    Cc: bpf@vger.kernel.org
    Link: https://lore.kernel.org/r/20231009183920.200859-8-irogers@google.comSigned-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    e2372136
env.c 12.2 KB