• Jean Delvare's avatar
    [PATCH] Fix i2c messsage flags in video drivers · e29f1773
    Jean Delvare authored
    While working on the saa7110 driver I found a problem with the way
    various video drivers (found on Zoran-based boards) prepare i2c messages
    to be used by i2c_transfer. The drivers improperly copy the i2c client
    flags as the message flags, while both sets are mostly unrelated. The
    net effect in this case is to trigger an I2C block read instead of the
    expected I2C block write. The fix is simply not to pass any flag,
    because none are needed.
    
    I think this patch qualifies hands down as a "critical bug fix" to be
    included in whatever bug-fix-only trees exist these days. As far as I
    can see, all Zoran-based boards are broken in 2.6.11 without this patch.
    Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
    Signed-off-by: default avatarChris Wright <chrisw@osdl.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    e29f1773
adv7175.c 14.1 KB