• Linus Lüssing's avatar
    batman-adv: fix potential TT client + orig-node memory leak · e46b9d49
    Linus Lüssing authored
    commit 9d31b3ce upstream.
    
    This patch fixes a potential memory leak which can occur once an
    originator times out. On timeout the according global translation table
    entry might not get purged correctly. Furthermore, the non purged TT
    entry will cause its orig-node to leak, too. Which additionally can lead
    to the new multicast optimization feature not kicking in because of a
    therefore bogus counter.
    
    In detail: The batadv_tt_global_entry->orig_list holds the reference to
    the orig-node. Usually this reference is released after
    BATADV_PURGE_TIMEOUT through: _batadv_purge_orig()->
    batadv_purge_orig_node()->batadv_update_route()->_batadv_update_route()->
    batadv_tt_global_del_orig() which purges this global tt entry and
    releases the reference to the orig-node.
    
    However, if between two batadv_purge_orig_node() calls the orig-node
    timeout grew to 2*BATADV_PURGE_TIMEOUT then this call path isn't
    reached. Instead the according orig-node is removed from the
    originator hash in _batadv_purge_orig(), the batadv_update_route()
    part is skipped and won't be reached anymore.
    
    Fixing the issue by moving batadv_tt_global_del_orig() out of the rcu
    callback.
    Signed-off-by: default avatarLinus Lüssing <linus.luessing@c0d3.blue>
    Acked-by: default avatarAntonio Quartulli <antonio@meshcoding.com>
    Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
    Signed-off-by: default avatarAntonio Quartulli <antonio@meshcoding.com>
    Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
    e46b9d49
originator.c 32.5 KB